Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds azure metadata provider to cloudmeta pkg. #4159

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

VAveryanov8
Copy link
Collaborator

@VAveryanov8 VAveryanov8 commented Dec 11, 2024

This adds azure metadata provider to cloudmeta pkg.

https://learn.microsoft.com/en-us/azure/virtual-machines/instance-metadata-service?tabs=linux#usage

I've tested this pr with official mock api from Azure - https://mockoon.com/mock-samples/azurecom-imds/ , but it's really far from real implementation, so it's better to validate this implementation against real Azure env.

Fixes: #4129


Please make sure that:

  • Code is split to commits that address a single change
  • Commit messages are informative
  • Commit titles have module prefix
  • Commit titles have issue nr. suffix

@VAveryanov8 VAveryanov8 marked this pull request as ready for review December 12, 2024 08:40
@VAveryanov8 VAveryanov8 self-assigned this Dec 12, 2024
@VAveryanov8
Copy link
Collaborator Author

This pr depends on #4154

pkg/cloudmeta/azure.go Outdated Show resolved Hide resolved
@karol-kokoszka
Copy link
Collaborator

karol-kokoszka commented Dec 12, 2024

I've tested this pr with official mock api from Azure - https://mockoon.com/mock-samples/azurecom-imds/ , but it's really far from real implementation, so it's better to validate this implementation against real Azure env.

Created the request for IT to get the access to Azure.

Dear Karol Kokoszka,

We would like to let you know that we have received your request and a ticket has been created.
A support representative will be reviewing your request and will send you a personal response.

To view the status of the ticket or add comments, please visit
https://scylladb.freshservice.com/helpdesk/tickets/441

Thank you for your patience.

Sincerely,
ScyllaDB IT Department

@VAveryanov8 VAveryanov8 force-pushed the va/cloudmeta-azure branch 2 times, most recently from 75ba63b to ada313e Compare December 12, 2024 16:33
Base automatically changed from va/cloudmeta-aws to master December 13, 2024 12:43
@Michal-Leszczynski
Copy link
Collaborator

@VAveryanov8 please rebase on master so that it's easier to analyze the changes.

@VAveryanov8
Copy link
Collaborator Author

@VAveryanov8 please rebase on master so that it's easier to analyze the changes.

Done!

@VAveryanov8
Copy link
Collaborator Author

VAveryanov8 commented Dec 17, 2024

update: I've manually tested this package on a real azure vm - everything seems to be working as expected!

This adds azure metadata provider to cloudmeta pkg.

Fixes: #4129
This adds http client with retries to project dependencies.
This adds retries to azure metadata service using the github.com/hashicorp/go-retryablehttp package.
Also adds some unit tests.
@VAveryanov8
Copy link
Collaborator Author

update: git rebase master

@VAveryanov8 VAveryanov8 merged commit 2fde888 into master Dec 17, 2024
51 checks passed
@VAveryanov8 VAveryanov8 deleted the va/cloudmeta-azure branch December 17, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibility to query instance metadata for Azure
4 participants