-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let other services use config cache #4166
Conversation
3561c16
to
dd51843
Compare
dd51843
to
c6a71a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@karol-kokoszka @VAveryanov8 sorry guys, I added one more commit to the PR. |
@Michal-Leszczynski I understand this PR just injects the service to other services that are going to use it, right ? |
But feel free to merge. |
Yea, but I already implemented a helper method for creating config cache svc in tests in this PR and it wasn't wasn't really working correctly (because of describes problem), so I wanted to keep it as a part of this PR. |
This is the first general step toward fixing #3892.
It allows for accessing config cache service from other services.
Actually using config cache service will be implemented in separate PRs.
Ref #3892