Skip to content

Commit

Permalink
transport/timestamp_generator: Added MonotonicTimestampGenerator
Browse files Browse the repository at this point in the history
Added TimestampGenerator trait and MonotonicTimestampGenerator based on c++ driver's implementation
  • Loading branch information
smoczy123 committed Dec 2, 2024
1 parent be14812 commit 3c0da90
Show file tree
Hide file tree
Showing 2 changed files with 94 additions and 0 deletions.
1 change: 1 addition & 0 deletions scylla/src/transport/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ pub mod retry_policy;
pub mod session;
pub mod session_builder;
pub mod speculative_execution;
pub mod timestamp_generator;
pub mod topology;

pub use crate::frame::{Authenticator, Compression};
Expand Down
93 changes: 93 additions & 0 deletions scylla/src/transport/timestamp_generator.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,93 @@
use std::{
ops::DerefMut,
sync::atomic::AtomicI64,
time::{SystemTime, UNIX_EPOCH},
};

use futures::lock::Mutex;
use std::sync::atomic::Ordering;
use tokio::time::{Duration, Instant};
use tracing::warn;

pub(crate) trait TimestampGenerator {
async fn next(&self) -> i64;
}

pub struct MonotonicTimestampGenerator {
last: AtomicI64,
last_warning: Mutex<Instant>,
warning_threshold_us: i64,
warning_interval_ms: i64,
}

impl MonotonicTimestampGenerator {
pub fn new_with_settings(warning_threshold_us: i64, warning_interval_ms: i64) -> Self {
MonotonicTimestampGenerator {
last: AtomicI64::new(0),
last_warning: Mutex::new(Instant::now()),
warning_threshold_us,
warning_interval_ms,
}
}
pub fn new() -> Self {
MonotonicTimestampGenerator::new_with_settings(1000000, 1000)
}

// This is guaranteed to return a monotonic timestamp. If clock skew is detected
// then this method will increment the last timestamp.
async fn compute_next(&self, last: i64) -> i64 {
let current = SystemTime::now().duration_since(UNIX_EPOCH);
if let Ok(cur_time) = current {
let u_cur = cur_time.as_micros() as i64;
if u_cur > last {
return u_cur;
} else if self.warning_threshold_us >= 0 && last - u_cur > self.warning_threshold_us {
let mut last_warn = self.last_warning.lock().await;
let now = Instant::now();
if now
>= last_warn
.checked_add(Duration::from_millis(self.warning_interval_ms as u64))
.unwrap()
{
*last_warn.deref_mut() = now;
drop(last_warn);
warn!(
"Clock skew detected. The current time ({}) was {} \
microseconds behind the last generated timestamp ({}). \
The next generated timestamp will be artificially incremented \
to guarantee monotonicity.",
u_cur,
last - u_cur,
last
)
}
}
} else {
warn!("Clock skew detected. The current time was behind UNIX epoch.");
}

last + 1
}
}

impl Default for MonotonicTimestampGenerator {
fn default() -> Self {
Self::new()
}
}

impl TimestampGenerator for MonotonicTimestampGenerator {
async fn next(&self) -> i64 {
loop {
let last = self.last.load(Ordering::SeqCst);
let cur = self.compute_next(last).await;
if self
.last
.compare_exchange(last, cur, Ordering::SeqCst, Ordering::SeqCst)
.is_ok()
{
return cur;
}
}
}
}

0 comments on commit 3c0da90

Please sign in to comment.