Skip to content

Commit

Permalink
semver_checks: Revert previous workaround
Browse files Browse the repository at this point in the history
The change in semver-checks was intentional and
`cargo install cargo-semver-checks --no-default-features`
is no longer expected to work. The replacement command is
`cargo install cargo-semver-checks --no-default-features --features gix-reqwest`.

See the release notes for v0.33.0: https://github.com/obi1kenobi/cargo-semver-checks/releases/tag/v0.33.0
  • Loading branch information
Lorak-mmk committed Aug 1, 2024
1 parent a0e7856 commit e79becf
Showing 1 changed file with 2 additions and 26 deletions.
28 changes: 2 additions & 26 deletions .github/workflows/semver_checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,20 +61,7 @@ jobs:
- name: Install semver-checks
# Official action uses binary releases fetched from GitHub
# If this pipeline becomes too slow, we should do this too.
#
# This works around the Semver violation in tame-index 0.12.2 that renders
# cargo-semver-checks incompilable. Once it gets fixed, revert back
# to using the newest release without customisations.
run: |
pushd ..
git clone https://github.com/obi1kenobi/cargo-semver-checks.git
cd cargo-semver-checks
git checkout v0.32.0
sed -i '0,/tame-index = { version = "0.12"/s//tame-index = { version = "=0.12.1"/' Cargo.toml
cargo build -r
cargo install --no-default-features --path .
popd
run: cargo install cargo-semver-checks --no-default-features --features gix-reqwest
- name: Verify the API compatibilty with PR base
id: semver-pr-check
run: |
Expand Down Expand Up @@ -160,17 +147,6 @@ jobs:
- name: Update rust toolchain
run: rustup update
- name: Install semver-checks
# This works around the Semver violation in tame-index 0.12.2 that renders
# cargo-semver-checks incompilable. Once it gets fixed, revert back
# to using the newest release without customisations.
run: |
pushd ..
git clone https://github.com/obi1kenobi/cargo-semver-checks.git
cd cargo-semver-checks
git checkout v0.32.0
sed -i '0,/tame-index = { version = "0.12"/s//tame-index = { version = "=0.12.1"/' Cargo.toml
cargo build -r
cargo install --no-default-features --path .
popd
run: cargo install cargo-semver-checks --no-default-features --features gix-reqwest
- name: Run semver-checks to see if it agrees with version updates
run: make semver-version

0 comments on commit e79becf

Please sign in to comment.