-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run all examples in the CI #839
Comments
I don't know any simple way to run all of the examples using a single command. We can just list every example as a separate step in the workflow, there aren't that many of them. |
Some of the examples cannot be just run like you would run a test - some of them require some CLI options ( IMO those tests that don't need any user input should just be integration tests or maybe examples in docstrings (and |
Since I'm the user who reported an error in one of the examples, I figured I'd open a PR #845 taking a look at running examples in CI. After running the examples in CI, I agree with @piodul that the examples aren't all consistent enough to run like you would run a test. Along with the examples @piodul highlighted, I just opened this issue #844 that I think is caused by two examples that use the same table naming conventions that cause the other to error when run against the same scylladb cluster. Also the I think a per-case basis certainly makes sense. Hope this little bit of work is helpful. |
The CI checks that all of the code examples compile, but it doesn't check whether they actually work.
The code is constantly evolving, and things that used to work in the past might stop working at some point, without anyone noticing.
In #835 a user reported that one of the examples doesn't work. It fails because the specified quorum is invalid for this type of request. This should've been caught in the PR that introduced this example, but wasn't.
It would be good to run all of the examples in the CI. This will help us catch all breakages.
The text was updated successfully, but these errors were encountered: