Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add workflow to run examples in ci #845

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nsipplswezey
Copy link
Contributor

#839 suggested putting examples into into CI. I took a look into doing so on my own fork. As @piodul pointed out, these examples are not all fundamentally similar. This PR excludes the cloud and tls examples since it seems like the cloud credentials may need to be reviewed and the tls example already runs in CI against a specific tls image.

Furthermore, when running all examples in series, tables persist between example runs causing errors when tables share names. See #844

Possible fix for #839

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@Lorak-mmk
Copy link
Collaborator

Sorry for the long wait.
Generally looks good to me, assuming that CI passes. I see that it didn't, but the logs already expired.
Could you rebase on current main, drop the merge commit and squash the remaining 2?
Then CI will run again and we'll see if everything works.

@Lorak-mmk Lorak-mmk added the waiting-on-author Waiting for a response from issue/PR author label Mar 14, 2024
@wprzytula
Copy link
Collaborator

@nsipplswezey What's the status of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-on-author Waiting for a response from issue/PR author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants