Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: disable tablets in CQL Counter's tests #1060

Merged

Conversation

wprzytula
Copy link
Collaborator

As tablets don't support counters yet, they need to be disabled in Counter type tests.
See scylladb/scylladb@c70f321.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • [] I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • [ ] I have provided docstrings for the public items that I want to introduce.
  • [ ] I have adjusted the documentation in ./docs/source/.
  • [ ] I added appropriate Fixes: annotations to PR description.

@wprzytula wprzytula requested a review from Lorak-mmk August 19, 2024 12:10
@wprzytula wprzytula self-assigned this Aug 19, 2024
Copy link

github-actions bot commented Aug 19, 2024

cargo semver-checks found no API-breaking changes in this PR! 🎉🥳
Checked commit: 35832d9

@wprzytula wprzytula requested a review from muzarski August 20, 2024 07:46
@wprzytula wprzytula added this to the 0.14.0 milestone Aug 20, 2024
scylla/src/transport/cql_types_test.rs Outdated Show resolved Hide resolved
As tablets don't support counters yet, they need to be disabled in
Counter type tests.
See scylladb/scylladb@c70f321.
@wprzytula wprzytula force-pushed the fix-counter-tests-not-to-use-tablets branch from e561ca9 to 35832d9 Compare August 21, 2024 11:34
@wprzytula wprzytula requested a review from Lorak-mmk August 21, 2024 11:34
@Lorak-mmk Lorak-mmk merged commit bac7f9e into scylladb:main Aug 21, 2024
11 checks passed
wprzytula pushed a commit to wprzytula/scylla-rust-driver that referenced this pull request Aug 22, 2024
…-to-use-tablets

tests: disable tablets in CQL Counter's tests
(cherry picked from commit bac7f9e)
@wprzytula wprzytula mentioned this pull request Aug 22, 2024
@wprzytula wprzytula deleted the fix-counter-tests-not-to-use-tablets branch October 2, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants