Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialization documentation #880

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Serialization documentation #880

merged 2 commits into from
Dec 15, 2023

Conversation

Lorak-mmk
Copy link
Collaborator

@Lorak-mmk Lorak-mmk commented Dec 14, 2023 •
edited by piodul
Loading

This PR adds warnings about changes introduced in #806 and #812 and updates documentation about new serialization API.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@Lorak-mmk Lorak-mmk marked this pull request as ready for review December 14, 2023 13:43
@Lorak-mmk Lorak-mmk force-pushed the serialization-documentation branch 2 times, most recently from dd79e3e to 115b084 Compare December 14, 2023 14:34
piodul
piodul reviewed Dec 14, 2023
View reviewed changes
docs/source/data-types/udt.md Outdated Show resolved Hide resolved
docs/source/data-types/udt.md Outdated Show resolved Hide resolved
docs/source/queries/paged.md Outdated Show resolved Hide resolved
docs/source/queries/simple.md Outdated Show resolved Hide resolved
scylla/src/transport/session.rs Outdated Show resolved Hide resolved
@Lorak-mmk Lorak-mmk force-pushed the serialization-documentation branch from 115b084 to bc97ffd Compare December 15, 2023 14:26
@Lorak-mmk
Copy link
Collaborator Author

v2:

  • Addressed review comments
  • Added note about rename attribute
  • Fixed formatting by removing unnecessary backslashes

@Lorak-mmk Lorak-mmk requested a review from piodul December 15, 2023 14:26
@piodul piodul merged commit 83d78b0 into scylladb:main Dec 15, 2023
9 checks passed
@Lorak-mmk Lorak-mmk mentioned this pull request Dec 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piodul piodul piodul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lorak-mmk @piodul