Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.11.0 #888

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Release 0.11.0 #888

merged 3 commits into from
Dec 19, 2023

Conversation

Lorak-mmk
Copy link
Collaborator

This PR is to review the changes required to release new version. It should NOT be merged, so I opened it as a draft.
After the approve, I will perform following steps (correct me if I'm wrong @piodul):

  • git checkout branch-0.11.x
  • git tag -a v0.11.0
  • git push origin v0.11.0
  • git checkout main
  • git merge --ff-only branch-0.11.x
  • git push origin main
  • Check that documentation was built and published successfully
  • Create a github release with previously approved release notes
  • Push new version to crates.io:
  • Create post on the forum about release

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@Lorak-mmk Lorak-mmk requested a review from piodul December 18, 2023 19:34
@Lorak-mmk Lorak-mmk changed the title Branch 0.11.x Release 0.11.0 Dec 18, 2023
@Lorak-mmk
Copy link
Collaborator Author

CI fails because:

  1. I didn't update Cargo.lock.msrv - will fix it in a moment
  2. Some issue with Sphinx theme. Opened and issue about it here: sphinx-scylladb-theme 1.6.4: No module named 'importlib_metadata' sphinx-scylladb-theme#966

@Lorak-mmk
Copy link
Collaborator Author

Fixed the Cargo.lock issue. Now the only release blocker is the sphinx theme issue :(

@piodul
Copy link
Collaborator

piodul commented Dec 18, 2023

The commits and the procedure looks good. Before giving approval, I'll wait until the docs issue is fixed and we get a green light on all jobs.

Copy link
Collaborator

@piodul piodul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs issue was fixed. Approving.

@Lorak-mmk Lorak-mmk merged commit 449ec0c into main Dec 19, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants