Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove strum and strum_macros dependencies #934

Merged
merged 3 commits into from
Feb 16, 2024

Conversation

muzarski
Copy link
Contributor

@muzarski muzarski commented Feb 15, 2024

Ref: #771

Motivation

strum and strum_macros are unstable crates and their usages need to be removed from the public API to stabilize it.

These crates are responsible for generating FromStr implementations for the types.

Changes

Replaced strum usages for NativeType and ColumnKind types with our own implementations of FromStr.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

Removed usages of `strum` crate from `NativeType` enum.
Replaced it with our own parsing logic.
Replaced strum crate usage for ColumnKind with our own implemnetation.
@muzarski muzarski requested review from Lorak-mmk and piodul and removed request for Lorak-mmk February 15, 2024 14:49
@piodul
Copy link
Collaborator

piodul commented Feb 16, 2024

The semver checks job silently failed here for the reason described here: #936. It looks like /dev/tty very recently stopped being available in our job runner's environment.

@piodul piodul added the API-breaking This might introduce incompatible API changes label Feb 16, 2024
@piodul piodul merged commit 87908f3 into scylladb:main Feb 16, 2024
11 checks passed
@Lorak-mmk Lorak-mmk mentioned this pull request May 9, 2024
@muzarski muzarski deleted the remove_strum_dependency branch October 29, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API-breaking This might introduce incompatible API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants