Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update theme 1.8 #20832

Closed
wants to merge 1 commit into from

Conversation

dgarcia360
Copy link
Contributor

@dgarcia360 dgarcia360 commented Sep 26, 2024

Related issue scylladb/sphinx-scylladb-theme#1229

ScyllaDB Sphinx Theme 1.8 is out 🥳!
image

Here's a summary of changes:

  • Dark theme support for a fresh new look.
  • Updated branding assets including new logos and mascots.
  • Improved build process by recommending the inclusion of the poetry.lock file to ensure consistent dependencies in your CI/CD pipeline.
  • New tooltip component to add more context to glossary terms, configuration parameters, or any other elements without cluttering the page.

You can read more about all the notable changes here.

How to test this PR

  1. Clone this PR.

  2. Enter the docs folder, and run:

    make preview
    
  3. Open http://localhost:5500 in your browser. The doc should render without errors, and the version should be Sphinx Theme version (see the footer) must be 1.8.x:

    image

@dgarcia360 dgarcia360 marked this pull request as draft September 26, 2024 08:23
@scylladb-promoter
Copy link
Contributor

scylladb-promoter commented Sep 26, 2024

Docs Preview 📖

Docs Preview for this pull request is available here

Changed Files:

Note: This preview will be available for 30 days and will be automatically deleted after that period. You can manually trigger a new build by committing changes.

chore: update README
@dgarcia360 dgarcia360 force-pushed the docs-update-theme-1.8 branch from fc8b6c1 to a6e9f67 Compare September 26, 2024 12:08
@dgarcia360 dgarcia360 marked this pull request as ready for review September 26, 2024 12:08
@annastuchlik annastuchlik added documentation Requires documentation backport/none Backport is not required labels Sep 26, 2024
Copy link
Collaborator

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annastuchlik annastuchlik added the status/merge candidate Item needs maintainer attention label Sep 26, 2024
@annastuchlik
Copy link
Collaborator

@denesb @kbr-scylla Please merge this PR. It updates the Sphinx theme, and we should make the update to all the projects at the same time.

description = "Scylla Documentation"
version = "4.3.0"
description = "ScyllaDB Documentation"
version = "0.1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does version change from 4.3 to 0.1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When installing the docs locally, it shows "Installing the current project: ... (4.3.0)" because the ScyllaDB version was 4.3.0 when the toolchain was installed. We updated the version in pyproject.toml to avoid confusion, as we won't be releasing the docs as a Python package.

@@ -0,0 +1,11 @@
version: 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do? Enable alerts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependabot will open automatic pull requests whenever the following packages receive updates:

  • "sphinx-scylladb-theme"
  • "sphinx-multiversion-scylla"

Previously, patch updates were automatically installed, but we’ve now changed the process so each project can control when to update. This automation simplifies that control.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kbr-scylla As a result, the maintainers of each project will have control over which version of the Sphinx theme is installed on the repo. I'll be reviewing the PRs opened by Dependabot, but it's up to the maintainers to merge them.

@kbr-scylla
Copy link
Contributor

Unfortunately I'm currently unable to queue the PR due to #20855

@kbr-scylla
Copy link
Contributor

Well, I'll just workaround this my own way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/none Backport is not required documentation Requires documentation promoted-to-master status/merge candidate Item needs maintainer attention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants