Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Feature/postgres grammar support UUID #261

Open
wants to merge 12 commits into
base: 0.9
Choose a base branch
from

Conversation

inventionlabsSydney
Copy link

UUID support as column type and as primary key type.
Can also search directly as type UUID.

@inventionlabsSydney
Copy link
Author

@sdispater Could you please merge this if you're okay with it?

@inventionlabsSydney
Copy link
Author

🙏

@josephmancuso
Copy link
Collaborator

@inventionlabsSydney I don't think @sdispater will have time to look at it. I've sudo taken over this project. I've been merging a lot of PR's lately and looking at issues as the Masonite framework (my main maintainer project) is slowing down and getting ready for a release.

My only problem with this (and I will test it when it's done) is that what about mysql and sqlite migrations?

If we merge this in what will happen when I merge it on a MySQL database? Orator is supposed to be database agnostic so we can't merge database specific features. It would either need to come as a feature of all 3 or map the UUID to something on mysql databases.

@inventionlabsSydney
Copy link
Author

Hey @josephmancuso Thanks so much for getting back to me.
So currently I'm working on MySQL and SQLite support for UUID.

I'm happy to hold off and provide those prior to merging, I can definitely see the rationale as to ensuring all DB's support all functionality.

Thanks,
Karl.

@rfschubert
Copy link

rfschubert commented Dec 23, 2018

Hey @inventionlabsSydney! Nice to meet you... I`m looking for same on Orator :) Need any help with MySQL and SQLite support for UUID ?

Maybe works like Django, using something like "extension" when build the table for Postgres, importing JSONField().

I'm still starting with Orator, so its possible I`m talking completely out of the scope.

@inventionlabsSydney
Copy link
Author

@rfschubert Hey sorry I was on holidays!

Yeah I'd really like someone to do the MySQL and SQLite support!

Lets go through it this week if you'd be okay with that?

@garyburgmann
Copy link

Where did this land? Still in development?

@mandarvaze
Copy link

@inventionlabsSydney @rfschubert Did either of you make progress on MySQL and SQLite support ?
I'm considering this PR for https://github.com/MasoniteFramework/orator

@inventionlabsSydney
Copy link
Author

Hey guys,
Sorry I haven't been responding I've been incredibly swamped.

I will work on this very shortly and get the base to work fro MySQL and SQLite.

@mandarvaze I'm going to sync with your fork and start making my changes.

@circulon
Copy link

circulon commented Nov 5, 2020

Bump
@inventionlabsSydney
Any ide on when this will be implemented please?

@digmunhoz
Copy link

Hello there.

Any update about it? It's quite important to avoid using uuid as a string and performance issue on databases

@RyanAquino
Copy link

Any update ? @inventionlabsSydney

@josephmancuso
Copy link
Collaborator

@circulon @RyanAquino @digmunhoz Have you guys looked into https://github.com/MasoniteFramework/orm? Its in version 1 at the moment and we could deff work on a solution to there

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants