-
Notifications
You must be signed in to change notification settings - Fork 174
add __file__ attribute when load .py config file #333
base: 0.9
Are you sure you want to change the base?
Conversation
@luoxiaohei Can you add a test case for I'm considering this PR for MasoniteFramework/orator fork |
@mandarvaze no problem! |
1914e1a
to
da0ee60
Compare
@mandarvaze Hi, I have added test cases, but CI seems to have some problems. I don't think my code is causing CI to fail. |
It is failing because some of the existing files aren't formatted "correctly", via Can you run If you are having error running the command , look here Finally, if you think it is too much, leave it. I can do it for you 😄 |
@mandarvaze Thank you! Now seems that everything is right. |
Great. We are almost there. One last thing: Can you squash your 3 commits into a single commit, so that I can cherry pick the combined one. Also, is this PR related to any open issue ? If yes, please mention. |
@mandarvaze I have squashed commits. There is no open issue related to it. |
@luoxiaohei Thanks for your contribution. This PR is merged to MasoniteFramework/orator fork : |
@josephmancuso Hi, Can you merge this PR? I want to create a new PR to fix the error occurred by source code installation. |
@luoxiaohei Feel free to create PR on MasoniteFramework/orator fork 😄 |
@mandarvaze OK! 😄 |
Fix the exception when use
__file__
attribute in .py config file.eg: