Adding Liquibase Candidate

[jandroav]

Hello team, we have a question about https://github.com/sdkman/sdkman-cli/wiki/Well-formed-SDK-archives.

We are already generating a zip file for liquibase. It almost complies with the Well-formed-SDK-archives guide except for the bin folder. We are shipping the executable in the root folder:

We are ok if we need to generate a different zip file for SDKMAM like the following:

But we would like to know if we could create a bin directory and symlink the required files into it (or move to bin and symlink to root dir). This involves the creation of a tar. which supports symbolic links instead of a zip file.

[helpermethod]

Hi @jandroav!

Because the respective bin directory is added to PATH by SDKMAN!, I suppose this should work out of the box.

[jandroav]

Thanks @helpermethod !

Is there anything else we need to do to have liquibase available in SDKMAN!?

[marc0der]

Hi @jandroav 👋
All that remains is requesting API keys to start publishing your versions. I'll do a quick stab to see if adding that bin folder with symlinks would work, although I suspect it would break on Windows (symlinks not supported). If not, you would need to provide a special zip archive that has the executable in the bin folder.

[marc0der]

Formatting failure @jandroav. Please see the README on how to run scalafmt.

[jandroav]

Formatting fixed and API creds requested. Thanks for your quick review on this @marc0der !

[marc0der]

Hi @jandroav, it looks like your code doesn't compile. You might need to look at some of the other migrations to see how it's done. You should probably use IntelliJ or VSCode with Metals. If not, at least use SBT to build and verify that it's correct. All instructions are in the README.

[jandroav]

Hi @marc0der, sorry, imports were missing. Now it builds.

[jandroav]

Hey @marc0der I see one build issue but I am not sure if it is related to my changelog: https://github.com/sdkman/sdkman-db-migrations/actions/runs/8060565235/job/22024825534

[helpermethod]

Hi @jandroav! The error is unrelated to your PR.

[jandroav]

Thanks @helpermethod !

How long does it usually take to have the PR merged and ready to upload versions to SDKMAN!?

I also sent an email from my liquibase email with our public key in plain text format.

[jnewton03]

hi @helpermethod @marc0der 😄 . Anything we can do to help get this moved forward? Thanks so much for your help!

[marc0der]

@jnewton03 @jandroav The problem was due to a dodgy migration, which I've now removed. I also rebased your PR against the updated master and merged it. GitHub doesn't always pick rebases so I'll close this PR now that it is merged.

[jandroav]

Thanks @marc0der ! We sent the last feb 26 a mail with our public key as shown here https://github.com/sdkman/sdkman-cli/wiki/Vendor-onboarding-process but we did not get a reply. Is there anything else we need to do to be able to send liquibase versions?

[marc0der]

No probs, I'll look into it shortly.

[jandroav]

Hi there, just a quick follow-up to remind you that we're eagerly awaiting approval of our public key to start using SDKMAN! for distributing Liquibase. Your assistance with this would be greatly appreciated. Thank you!