Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spark 3.5.1 and older patches #696

Closed
wants to merge 1 commit into from

Conversation

cphbrt
Copy link
Contributor

@cphbrt cphbrt commented Jun 11, 2024

Hi! I've made similar contributions to this repo in #672 and #614.

The primary goal of this PR is to add Spark 3.5.1. I added the other missing patch versions back to 2.0.2, the oldest available in sdkman. Let me know if that was too ambitious, and I can remove those and leave 3.5.1.

Updates:

  • Force push 9dfa4a4 fixed a missing author field in a ChangeSet annotation.

@marc0der
Copy link
Member

marc0der commented Jun 16, 2024

Hi @cphbrt , you could collapse all of them into a single changeset like you will see elsewhere in the code. You can also remove the old change sets that have become obsolete. We're trying to stop this project from expanding as much as possible to keep the build time down.

@cphbrt
Copy link
Contributor Author

cphbrt commented Jun 17, 2024

👍 Agreed. I didn't think about the accruing changesets. Updated accordingly. Thanks!

@marc0der
Copy link
Member

Hey @cphbrt , I'v pushed some changes on my local branch for future reference. If you're happy with that, I can merge it:
https://github.com/sdkman/sdkman-db-migrations/pull/698/files

@marc0der
Copy link
Member

I merged my branch (which has your commit in), but GH isn't smart enough to pick that up. Closing this PR, but rest assured, your changes are in there 💪

Thanks for contributing. It's a great help!

@marc0der marc0der closed this Jun 21, 2024
@cphbrt
Copy link
Contributor Author

cphbrt commented Jun 21, 2024

@marc0der Elegant approach to handling the version and distribution variation. Thank you for working through it with me. Cheers!

@marc0der
Copy link
Member

My pleasure, and thanks again for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants