Skip to content

Commit

Permalink
Improvements for future uptake of `org.gradle.unsafe.isolated-project…
Browse files Browse the repository at this point in the history
…s=true`.
  • Loading branch information
ianbrandt committed Nov 5, 2024
1 parent 6469754 commit 9ef01c9
Show file tree
Hide file tree
Showing 9 changed files with 19 additions and 21 deletions.
3 changes: 3 additions & 0 deletions build-logic/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ plugins {
`kotlin-dsl`
}

group = "org.sdkotlin.buildlogic"
version = "1.0.0-SNAPSHOT"

dependencies {

implementation(platform("org.sdkotlin.platforms:plugins-platform"))
Expand Down
14 changes: 0 additions & 14 deletions build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,6 @@ plugins {
alias(libs.plugins.versions.gradle.plugin)
}

allprojects {
group = "org.sdkotlin"
version = "1.0-SNAPSHOT"
}

subprojects {
tasks {
register<DependencyReportTask>("allDependencies") {
description = "Display dependencies report for all subprojects."
group = "help"
}
}
}

dependencyAnalysis {
issues {
all {
Expand Down
2 changes: 1 addition & 1 deletion detekt-rules/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ plugins {
}

group = "org.sdkotlin.detekt"
version = "1.0-SNAPSHOT"
version = "1.0.0-SNAPSHOT"

dependencies {

Expand Down
3 changes: 3 additions & 0 deletions gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ org.gradle.jvmargs=-Xmx4g
org.gradle.kotlin.dsl.skipMetadataVersionCheck=false
org.gradle.parallel=true

# KSP and Gradle Versions Plugin `dependencyUpdates` task fails with:
#org.gradle.unsafe.isolated-projects=true

ksp.useKSP2=true

dependency.analysis.print.build.health=true
2 changes: 0 additions & 2 deletions platforms/app-platform/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ plugins {
id("java-platform")
}

group = "org.sdkotlin.platforms"

javaPlatform {
allowDependencies()
}
Expand Down
2 changes: 0 additions & 2 deletions platforms/plugins-platform/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ plugins {
id("java-platform")
}

group = "org.sdkotlin.platforms"

dependencies {
constraints {
api(libs.dependency.analysis.gradle.plugin.dependency)
Expand Down
6 changes: 6 additions & 0 deletions platforms/settings.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@ dependencyResolutionManagement {

rootProject.name = "platforms"

gradle.beforeProject {
// Set group and version properties for all projects
group = "org.sdkotlin.platforms"
version = "1.0.0-SNAPSHOT"
}

include("app-platform")
include("test-platform")
include("plugins-platform")
2 changes: 0 additions & 2 deletions platforms/test-platform/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ plugins {
id("java-platform")
}

group = "org.sdkotlin.platforms"

javaPlatform {
allowDependencies()
}
Expand Down
6 changes: 6 additions & 0 deletions settings.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,12 @@ rootProject.name = "sd-kotlin-talks"

includeBuild("platforms")

gradle.beforeProject {
// Set group and version properties for all projects
group = "org.sdkotlin"
version = "1.0.0-SNAPSHOT"
}

include("subprojects:di-with-koin")
include("subprojects:effective-kotlin")
include("subprojects:kotlin-dl")
Expand Down

0 comments on commit 9ef01c9

Please sign in to comment.