Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm64: dts: qcom: sdm660-xiaomi-lavender: Split by display #26

Merged
merged 5 commits into from
Apr 25, 2024
Merged

arm64: dts: qcom: sdm660-xiaomi-lavender: Split by display #26

merged 5 commits into from
Apr 25, 2024

Conversation

barni2000
Copy link

Xiaomi Redmi Note 7 (lavender) has two variant one with tianma display
with novatek touchscreen and one with boe display with synpatics
touchscreen. These changes split lavender devicetree by display.

@minlexx
Copy link
Member

minlexx commented Apr 23, 2024

Why draft? not tested?

@barni2000
Copy link
Author

barni2000 commented Apr 23, 2024

Why draft? not tested?

Boe variant is tested, maybe i should add copyright comments and thinking about change td4320 compatible name.

@barni2000 barni2000 marked this pull request as ready for review April 23, 2024 23:39
@minlexx
Copy link
Member

minlexx commented Apr 24, 2024

And I think -common.dtsi should not contain model/compatible = ? need to check what's inside other commons

@minlexx
Copy link
Member

minlexx commented Apr 24, 2024

I've tested it on my variant and as-is display doesn't come online due to panel compatible missing -simple.

@minlexx minlexx force-pushed the qcom-sdm660-6.8.y branch from 9429e8f to 9499484 Compare April 24, 2024 13:11
Enable display susystem, Adreno GPU and all required nodes,
such as iommus, gpucc and DSI PHY.
Add panel node.

Relocate zap-shader memory region to avoid CPU stalls.

Signed-off-by: Alexey Minnekhanov <[email protected]>
@barni2000
Copy link
Author

And I think -common.dtsi should not contain model/compatible = ? need to check what's inside other commons

I have modified like xiaomi-berillyum at sdm845-mainline

Copy link
Member

@minlexx minlexx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add new panel driver as module (CONFIG_DRM_PANEL_BOE_TD4320=m) to https://github.com/sdm660-mainline/linux/blob/qcom-sdm660-6.8.y/arch/arm64/configs/sdm660_defconfig otherwise it might get lost and forgotten.

Also maybe fix all FIXMEs in panel driver... and it will be in upstreamable state, I hope (almost...)

drivers/gpu/drm/panel/panel-td4320-boeplus.c Outdated Show resolved Hide resolved
drivers/gpu/drm/panel/panel-td4320-boeplus.c Outdated Show resolved Hide resolved
Xiaomi Redmi Note 7 (lavender) has two variant one with tianma display
with novatek touchscreen and one with boe display with synpatics
touchscreen. These changes split lavender devicetree by display.

Signed-off-by: Barnabás Czémán <[email protected]>
Add boe td4320 DSI panel driver.

Signed-off-by: Barnabás Czémán <[email protected]>
Add compatibles for Xiaomi Redmi Note 7 (lavender) variants.

Signed-off-by: Barnabás Czémán <[email protected]>
Add CONFIG_DRM_PANEL_BOE_TD4320 as a module.

Signed-off-by: Barnabás Czémán <[email protected]>
@minlexx
Copy link
Member

minlexx commented Apr 24, 2024

Great, thanks! Needs some testing on real hw and then probably good to go

@minlexx minlexx merged commit e0c3b64 into sdm660-mainline:qcom-sdm660-6.8.y Apr 25, 2024
1 check passed
@minlexx
Copy link
Member

minlexx commented Apr 25, 2024

Works fine here, thanks!

@barni2000 barni2000 deleted the lavender_split branch April 26, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants