Add RSpec Hook to PreCommit, Add Applicable files if set #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create shared r_spec hook from previous hook in pre_push * Create hook in pre_commit including shared hook * Update hook in pre_push to use shared hook
* If 'include' is set on Rspec pass those files to be run by rspec * Check performed to maintain backwards compatibility
|
Thanks for the contribution! Sorry for the delay in merging. Fixed RuboCop errors and merged in #842. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently added this functionality to one of our own Repos and thought we should share.
This change requires the 'include' parameter to be set before it uses the 'applicable_files' function. Is this the correct way to do this? Should we create a new parameter for this behaviour?
Referenced Issue: #703