Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] New pre-commit hook: Sorbet (Issue #825) #826

Merged
merged 2 commits into from
Feb 25, 2024

Conversation

fulf
Copy link
Contributor

@fulf fulf commented Feb 24, 2024

Introduction

This pre-commit hook runs the Sorbet type-checker.
More information about Sorbet here

Fixes #825

Requirements

Sorbet

Notes: not sure if this should be a pre-commit hook or pre-push hook to be honest.

@sds sds enabled auto-merge (squash) February 24, 2024 23:56
@sds sds disabled auto-merge February 24, 2024 23:56
@sds sds merged commit a2fb742 into sds:main Feb 25, 2024
7 checks passed
@sds
Copy link
Owner

sds commented Feb 25, 2024

Thanks for all the effort!

@bmulholland
Copy link

Just stumbled upon this. One note is that sorbet runs across all cores by default, so parallelize should be false by default, I think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PreCommit support for Sorbet
3 participants