Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flake8-fixme #294

Merged
merged 9 commits into from
Nov 23, 2021
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions copulas/multivariate/vine.py
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,6 @@ def train_vine(self, tree_type):

def get_likelihood(self, uni_matrix):
"""Compute likelihood of the vine."""
# TODO: explain what this is supposed to do and make it work
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll open an issue for this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link the issue here?

Copy link
Member Author

@fealho fealho Nov 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, #303.

# TODO: Alternatively, remove it.
num_tree = len(self.trees)
values = np.empty([1, num_tree])

Expand Down
1 change: 1 addition & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
'flake8-debugger>=4.0.0,<4.1',
'flake8-mock>=0.3,<0.4',
'flake8-mutable>=1.2.0,<1.3',
'flake8-fixme>=1.1.1,<1.2',

# fix style issues
'autoflake>=1.1,<2',
Expand Down