Add REalTabFormer to supported synthesizers #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristid9
force-pushed
the
realtabformer_custom_synthesizer
branch
from
4b6b947 to
58bd0d4
Compare
pvk-developer
requested changes
Nov 13, 2024
amontanez24
reviewed
Nov 13, 2024
amontanez24
reviewed
Nov 14, 2024
cristid9
force-pushed
the
realtabformer_custom_synthesizer
branch
9 times, most recently
from
12a1495 to
43d446e
Compare
amontanez24
requested changes
Nov 20, 2024
pvk-developer
requested changes
Nov 25, 2024
cristid9
force-pushed
the
realtabformer_custom_synthesizer
branch
4 times, most recently
from
a64d60f to
5593604
Compare
cristid9
force-pushed
the
realtabformer_custom_synthesizer
branch
2 times, most recently
from
1b279c9 to
b679a3c
Compare
cristid9
force-pushed
the
realtabformer_custom_synthesizer
branch
from
0ab4148 to
b84a641
Compare
amontanez24
requested changes
Dec 10, 2024
amontanez24
reviewed
Dec 10, 2024
tests/integration/test_benchmark.py
Outdated
Comment on lines
91
to
92
| assert train_time >= 0 | ||
| assert sample_time >= 0 |
There was a problem hiding this comment.
Why is the sample time 0 for windows? Is it crashing or rounding incorrectly?
amontanez24
requested changes
Dec 10, 2024
pvk-developer
requested changes
Dec 11, 2024
amontanez24
approved these changes
Dec 11, 2024
pvk-developer
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #347
CU-86b2czk01