Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Prepare Release workflow #681

Closed
wants to merge 5 commits into from
Closed

Create Prepare Release workflow #681

wants to merge 5 commits into from

Conversation

amontanez24
Copy link
Contributor

@amontanez24 amontanez24 commented Dec 2, 2024 •
edited
Loading

resolves #674

@amontanez24 amontanez24 marked this pull request as ready for review December 2, 2024 21:06
@amontanez24 amontanez24 requested a review from a team as a code owner December 2, 2024 21:06
@amontanez24 amontanez24 requested review from gsheni and removed request for a team December 2, 2024 21:06
@amontanez24 amontanez24 marked this pull request as draft December 2, 2024 21:06
@codecov Codecov
Copy link

codecov bot commented Dec 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.19%. Comparing base (ac19c4d) to head (70b8636).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #681   +/-   ##
=======================================
  Coverage   94.19%   94.19%           
=======================================
  Files         105      105           
  Lines        3947     3947           
=======================================
  Hits         3718     3718           
  Misses        229      229
Flag Coverage Δ
integration 78.10% <ø> (ø)
unit 79.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amontanez24 amontanez24 marked this pull request as ready for review December 3, 2024 00:08
@amontanez24 amontanez24 requested review from R-Palazzo and frances-h and removed request for gsheni December 3, 2024 00:09
R-Palazzo
R-Palazzo reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@R-Palazzo R-Palazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
From the issue, we have to also delete the static_code_analysis.yml worfklow.

@R-Palazzo R-Palazzo self-requested a review December 3, 2024 18:18
@amontanez24
Copy link
Contributor Author

Looks good! From the issue, we have to also delete the static_code_analysis.yml worfklow.

done

@amontanez24
Copy link
Contributor Author

Closing since the PR seems to be broken on Github's end. Will open a new one after

@amontanez24 amontanez24 closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@R-Palazzo R-Palazzo R-Palazzo approved these changes

@frances-h frances-h frances-h approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Prepare Release workflow
3 participants
@amontanez24 @frances-h @R-Palazzo