Add option to process tract without address in FHIR ETL #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencap
reviewed
Dec 1, 2023
lib/id3c/cli/command/etl/fhir.py
Outdated
| tract = get_tract(location) | ||
| tract_hierarchy = tract.hierarchy | ||
| tract_id = tract.id | ||
| except: |
There was a problem hiding this comment.
We should generally try to avoid blanket except statements. Are we trying to catch the AssertionError here in the case that the tract is unknown? Maybe we are also trying to catch the AttributeError in the case of tract.hierarchy not being defined?
lib/id3c/cli/command/etl/fhir.py
Outdated
| @@ -860,7 +869,8 @@ def process_address(location: Location, tract_hierarchy: str) -> Optional[Any]: | |||
| upsert_encounter_location(db, | |||
| encounter_id = encounter_id, | |||
| relation = relation, | |||
| location_id = address.id) | |||
| location_id = address.id if address else tract_id) | |||
There was a problem hiding this comment.
You could just use tract.id directly here instead of creating a new tract_id variable.
sallybg
force-pushed
the
process_tract_only
branch
from
90366b0
to
968ee3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the process_location function, called as part of the etl fhir function, assumed that the encounter location was an address with a tract as a parent location. Sample metadata received as part of KP2023 do not contain addresses, only census tracts, so process_location now handles encounter locations that are just tracts with no address and no parent location.