Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CDPMsgIPPrefix in contrib.cdp when length is more than one IP address #4585

Merged
merged 5 commits into from
Nov 23, 2024

Conversation

itform-fr
Copy link
Contributor

if the length of IP addresses prefixes was more than one address all the following content wasn't interpreted (Raw payload). This change seams to fix it

Here the capture with multiple addresses in the CDPIPPrefix
CDP Wireshark

Here the cdp.py dissector before modification with the pcap showed before
CDP IPPrefix length error

Here the cdp.py dissector after modification with the same pcap
CDP IPPrefix length error fix

That's my first participation, hope it can help

if the length of IP addresses prefixes was more than one address all the following content wasn't interpreted (Raw payload). This seams to fix it
A better approach with a list rather than packets
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.63%. Comparing base (8e08cbf) to head (0ce7d2d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
scapy/contrib/cdp.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4585   +/-   ##
=======================================
  Coverage   81.62%   81.63%           
=======================================
  Files         358      358           
  Lines       85652    85656    +4     
=======================================
+ Hits        69915    69922    +7     
+ Misses      15737    15734    -3     
Files with missing lines Coverage Δ
scapy/contrib/cdp.py 94.90% <75.00%> (-0.53%) ⬇️

... and 4 files with indirect coverage changes

---- 🚨 Try these New Features:

gpotter2
gpotter2 previously approved these changes Nov 21, 2024
Copy link
Member

@gpotter2 gpotter2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR ! Looks good

@gpotter2 gpotter2 merged commit 680107d into secdev:master Nov 23, 2024
24 checks passed
@itform-fr
Copy link
Contributor Author

Thank you for all the great work with this awesome project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants