refactor: add max available executors to error

sedaprotocol · Aug 13, 2024 · b6c3a80 · b6c3a80
1 parent 77770ae
commit b6c3a80
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/contract/src/error.rs b/contract/src/error.rs
@@ -43,9 +43,9 @@ pub enum ContractError {
     #[error("DataRequestAlreadyExists: Data request already exists")]
     DataRequestAlreadyExists,
     #[error(
-        "ReplicationFactorExceedsExecutorCount: The specified replication factor exceeds the available number of executors"
+        "ReplicationFactorExceedsExecutorCount: The specified replication factor exceeds the available number of executors ({0})"
     )]
-    DataRequestReplicationFactorTooHigh,
+    DataRequestReplicationFactorTooHigh(usize),
     #[error("Invalid payback address")]
     InvalidPaybackAddr,
     #[error("IneligibleExecutor: Caller is not an eligible data request executor")]

diff --git a/contract/src/msgs/data_requests/execute/post_request.rs b/contract/src/msgs/data_requests/execute/post_request.rs
@@ -19,7 +19,7 @@ impl ExecuteHandler for execute::post_request::Execute {
             .keys(deps.storage, None, None, cosmwasm_std::Order::Ascending)
             .count();
         if usize::from(self.posted_dr.replication_factor) > stakers_length {
-            return Err(ContractError::DataRequestReplicationFactorTooHigh);
+            return Err(ContractError::DataRequestReplicationFactorTooHigh(stakers_length));
         }
 
         // TODO: verify the payback non seda address...

diff --git a/contract/src/msgs/data_requests/tests.rs b/contract/src/msgs/data_requests/tests.rs
@@ -911,5 +911,5 @@ fn post_data_request_replication_factor_too_high() {
     // expect an error when trying to post it again
     let dr = test_helpers::calculate_dr_id_and_args(1, 2);
     let res = test_info.post_data_request(&sender, dr.clone(), vec![], vec![1, 2, 3], 1);
-    assert!(res.is_err_and(|x| x == ContractError::DataRequestReplicationFactorTooHigh));
+    assert!(res.is_err_and(|x| x == ContractError::DataRequestReplicationFactorTooHigh(2)));
 }