Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: clone cleaning #144

Merged
merged 7 commits into from
May 14, 2024
Merged

Conversation

gluax
Copy link
Collaborator

@gluax gluax commented May 13, 2024

Motivation

To clean up the usage of clone throughout the code base.

Explanation of Changes

The scary number of charges is because of formatting rule changes :).

  1. Separated tests into a separate file where appropriate(if there were more than a few). So I could search for clones outside of the test and test utils.
  2. Realized the Map type from cosmwasm lets you have a reference to a key due to phantom typing and clever referencing.
  3. Removed as many clones as I saw possible. This seldom resulted in lines of code re-ordering.
  4. I added more rustfmt rules. Some stuff was messy due to my clean-ups so far, but I didn't want to fix it by hand, lol.
  5. Updated basic CI to be faster, by putting clippy and test into the same job. Also to use nightly for fmt. Also updated the actions while I was at it.

Testing

All tests still pass.

Related PRs and Issues

Progresses #142.

@gluax gluax requested review from FranklinWaller and mariocao May 13, 2024 21:05
@gluax gluax self-assigned this May 13, 2024
@mariocao mariocao merged commit ade97b3 into refactor/public-keys-and-new-dr May 14, 2024
2 checks passed
@gluax gluax deleted the chore/clone-cleaning branch May 15, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants