Feat: account seq #164
Merged
Feat: account seq #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariocao
reviewed
Jun 4, 2024
FranklinWaller
approved these changes
Jun 5, 2024
mariocao
reviewed
Jun 5, 2024
mariocao
reviewed
Jun 5, 2024
There was a problem hiding this comment.
I wanted also to discuss if it makes sense to add the sequence number to all execute messages or only to the unstake and withdraw (which are the sensitive methods). I was updating the overlay and it felt weird that we only increase the sequence number on only 2 functions.
Also, we could remove the unregister for whenever you withdraw and your funds are equal to zero. We could even unify the register and increase stake to simply stake(public_key, amount, memo).
What are your opinions @gluax and @FranklinWaller ?
mariocao
reviewed
Jun 5, 2024
mariocao
reviewed
Jun 5, 2024
mariocao
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to avoid replay attacks.
Explanation of Changes
Add a sequence number. And use it for some messages.
Testing
All tests still pass.
Related PRs and Issues
N/A