chore: Gen Tally Test Fixtures #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gluax
changed the title
mariocao
approved these changes
Jun 5, 2024
|
Not for now, but maybe we could document the available xtask commands somewhere. |
|
I most certainly need to update the developing section all around lol |
gluax
force-pushed
the
chore/tally-test-fixtures
branch
from
9ba44ac to
7ad013c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
An easy way to generate tally test fixtures.
Explanation of Changes
Simple Data request generation for unit testing results of data_requests ready to be tallied.
You can see the code in
xtask/src/main.rs. These are overly simplified at the moment, and tally inputs are only numbers(I am I'm not sure I built them correctly because they aren't RLP encoded).cargo tally-data-req-fixture. It generates a filetally_data_request_fixture.json.Testing
Command works.
Related PRs and Issues
N/A