Return DR ID as hex string instead of an encoded byte array #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gluax
approved these changes
Jun 24, 2024
mariocao
approved these changes
Jun 24, 2024
gluax
reviewed
Jun 24, 2024
| @@ -48,7 +48,7 @@ pub fn calculate_dr_id_and_args(nonce: u128, replication_factor: u16) -> PostDat | |||
| } | |||
|
|
|||
| pub fn construct_dr( | |||
| constructed_dr_id: Hash, | |||
| constructed_dr_id: &String, | |||
| pub fn commit_result( | ||
| &mut self, | ||
| sender: &TestExecutor, | ||
| dr_id: &String, |
There was a problem hiding this comment.
And there were a few more places.
mariocao
force-pushed
the
fix/output-dr_id-hex
branch
from
09deaa9 to
33859fb
Compare
mariocao
force-pushed
the
fix/output-dr_id-hex
branch
from
33859fb to
3837a51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Makes interacting with the contract easier by removing 1 layer of encoding/decoding.
Explanation of Changes
Fairly straightforward, except since I changed some types I had to modify a lot of existing test code. If there's a better way to do this please educate me :)
Testing
All the tests still pass.
Related PRs and Issues
N.A.