refactor(dr): remove seq number in commit and reveal hash #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Most contract transactions include a hashed value derived from variables like dr_id, block_height, and sequence_number. This approach helps protect transactions from replay attacks, where a malicious user could resend previous transactions to perform actions such as staking, unstaking, and withdrawing.
For consistency, this mechanism was also applied to data_request transactions. However, because identities might submit multiple commit and reveal transactions simultaneously, including the sequence_number adds complexity and affects the performance of an executor node using the same identity for multiple data requests. The dr_id and block_height variables are sufficient to protect data request transactions.
Explanation of Changes
Remove the sequence_number from the hash value in contract transactions.
Testing
Remove the sequence_number from the hash value in contract transactions.