Fix/swap remove #180
Merged
Fix/swap remove #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Franklin Waller <[email protected]>
gluax
requested review from
Thomasvdam,
FranklinWaller,
mariocao and
hacheigriega
mariocao
approved these changes
Jun 27, 2024
FranklinWaller
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When posting a result, the old status key stuck around, which caused issues on the chain side.
Explanation of Changes
Adds some new tests for cases not previously thought of.
Re-wrote the swap remove to be more clear with a lot more comments.
Testing
All tests, new and old, pass.
Related PRs and Issues
N/A