Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Batching means less calls = goodness.
Explanation of Changes
I moved the logic for posting a result and creating an event to a common function.
Handler is now implemented on the
PostResult
type to retain thepost_result
behavior.Implements the
PostDataResults
method. I don't collect the events to avoid allocations.Testing
Add new tests.
Related PRs and Issues
Don't merge till sedaprotocol/seda-common-rs#12 is merged and we update the
seda-common
dep to point tomain
.Closes #181.