Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update events emitted for DR execution messages #192

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

Thomasvdam
Copy link
Member

Motivation

Some of the new attributes were not yet emitted.

Explanation of Changes

Added the consensus_filter attribute to the post DR handler.

Changed the executor to the public key string instead of the address that signed the message, as the SEDA address is no longer the identifier for the identity that submitted a commit/reveal.

Testing

Verified existing tests still pass.

Related PRs and Issues

N.A.

@Thomasvdam Thomasvdam requested review from FranklinWaller, gluax and a team July 22, 2024 13:36
@Thomasvdam Thomasvdam merged commit 53bbcea into main Jul 22, 2024
2 checks passed
@Thomasvdam Thomasvdam deleted the chore/emit-dr-attributes branch July 22, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants