Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: clean integration tests #208

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Chore: clean integration tests #208

merged 2 commits into from
Aug 21, 2024

Conversation

gluax
Copy link
Collaborator

@gluax gluax commented Aug 20, 2024

Motivation

To see if we were missing any tests from the old integration tests.

Explanation of Changes

Removed unused error variants.
Removed old integration tests. I didn't see any that had logic we didn't do, asides from governance which is no longer relevant.

Testing

All tests still pass.

Related PRs and Issues

Closes #198

@gluax gluax self-assigned this Aug 20, 2024
Copy link
Member

@Thomasvdam Thomasvdam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@gluax gluax merged commit 8439367 into main Aug 21, 2024
2 checks passed
@gluax gluax deleted the chore/clean-integration-tests branch August 21, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔧 Review & Clean Old Integration Tests
3 participants