chore: instantiate msg qol #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomasvdam
approved these changes
Nov 27, 2024
|
Whoops did not mean to merge that yet, thought I was in common :x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To allow specifying the config options at instantiate.
Explanation of Changes
Now you can override the defaults.
I realized the uint128 new is const so changed that.
Testing
All tests still pass.
Related PRs and Issues
waiting for sedaprotocol/seda-common-rs#32 to merge. and also tag a release.
I'd also like us to decide on better defaults for the minimum amount to stake/timeouts, as we get ready for devnet 5 and mainnet.