Return posted height along dr_id on post_data_request #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomasvdam
force-pushed
the
feat/post-dr-return-height
branch
from
24fe960 to
7fdbdf4
Compare
mariocao
reviewed
Dec 2, 2024
Comment on lines
7
to
11
| pub(crate) struct PostRequestResponse { | ||
| pub dr_id: String, | ||
| pub height: u64, | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| pub(crate) struct PostRequestResponse { | |
| pub dr_id: String, | |
| pub height: u64, | |
| } | |
| pub(crate) struct PostRequestData { | |
| pub dr_id: String, | |
| pub height: u64, | |
| } | |
Also satisfy clippy.
Thomasvdam
force-pushed
the
feat/post-dr-return-height
branch
from
7fdbdf4 to
73e6a68
Compare
gluax
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Allow solvers to accurately track the DR that they posted and reduce the risk of forwarding an old result.
Explanation of Changes
Updated the test utility to verify the response and forward just the
dr_idso we don't have to change all the tests.Testing
Tests still pass.
Related PRs and Issues
N.A.