-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: funds distribution #244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With our current design this won't work since we don't register a SEDA address for an executor node.
I think we should differentiate between data proxy payouts and executor payouts. Data proxy is a simple bank transfer, but an executor payout is an internal accounting change on the contract with the funds staying on the contract.
We discussed having moving the funds to the identities' staking pool, and anything that exceeds the minimum_to_stake amount goes straight to the to_withdraw pool. Given that we're starting with an allowlisted pool of executors we could opt to simplify this and always move it to one of them.
Oh I totally forgot about that it's been so long since we talked about it. So need to add another I realized it could still use the DistributionSend Message, and we can match on the |
Right now an executor has |
contract/Cargo.toml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to bump the version here too? Or not yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot I'll do that now ^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in #242.
8aa052d
to
dd80661
Compare
|
||
if !dr_escrow.amount.is_zero() { | ||
bank_messages.push(BankMsg::Send { | ||
to_address: dr_escrow.staker.to_string(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be poster
to_address: dr_escrow.staker.to_string(), | |
to_address: dr_escrow.poster.to_string(), |
Motivation
Distribution of data request escrow funds.
Explanation of Changes
Testing
Related PRs and Issues
Waiting for sedaprotocol/seda-common-rs#34 to be merged so we can update common to main.
Closes #243