♻️ Split seda-chain-contracts into DataRequests and Staking
#61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gluax
approved these changes
Sep 14, 2023
jamesondh
force-pushed
the
refactor/split-contract
branch
from
2ed2451 to
c7a23d4
Compare
Thomasvdam
approved these changes
Sep 22, 2023
Comment on lines
+33
to
+34
| /// Posts a data result of a data request with an attached hash of the answer and salt. | ||
| /// This removes the data request from the pool and creates a new entry in the data results. |
There was a problem hiding this comment.
I think this comment is no longer accurate?
Comment on lines
+62
to
+63
| /// Posts a data result of a data request with an attached result. | ||
| /// This removes the data request from the pool and creates a new entry in the data results. |
There was a problem hiding this comment.
Same here, but I guess the focus is on splitting stuff in this PR 😅
gluax
approved these changes
Sep 22, 2023
| @@ -136,7 +137,7 @@ jobs: | |||
| devAccount=${{ env.DEV_ACCOUNT }} | |||
| if [[ "${{ github.event.inputs.contract }}" != "proxy_contract" ]]; then | |||
| proxy=${{ github.event.inputs.proxy }} | |||
| OUTPUT=$(./seda-chaind tx wasm instantiate ${{ env.code_id }} '{"token":"aseda","proxy":"${proxy}"}' --no-admin --from ${devAccount} --node ${nodeUrl} --keyring-dir . --keyring-backend test --label ${{ env.code_id }} --gas-prices 0.1aseda --gas auto --gas-adjustment 1.3 -y --output json) | |||
| OUTPUT=$(./seda-chaind tx wasm instantiate ${{ env.code_id }} '{"token":"aseda", "proxy": ${{ toJSON(github.event.inputs.proxy) }} }' --no-admin --from ${devAccount} --node ${nodeUrl} --keyring-dir . --keyring-backend test --label ${{ env.code_id }} --gas-prices 0.1aseda --gas auto --gas-adjustment 1.3 -y --output json) | |||
mariocao
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To facilitate separation of concerns and easier upgradability.
Explanation of Changes
seda-chain-contractsintoDataRequestsandStakingcheck_eligibilityinDataRequeststo use a cross-contract query to the proxy to check whether a DR executor is eligibleTesting
Moved some unit tests involving commit/reveal to integration tests, since they require active data request executors
Related PRs and Issues
Closes #56