refactor: return dr_id in response.data in PostDataRequest message
#66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesondh
changed the title
PostDataRequest messaegPostDataRequest message
jamesondh
force-pushed
the
fix/update-hashing
branch
from
5861631 to
39e8bf9
Compare
mariocao
approved these changes
Sep 22, 2023
Thomasvdam
approved these changes
Sep 22, 2023
jamesondh
force-pushed
the
refactor/response-data
branch
from
ea62f75 to
6845a35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Query responses return a Response with the data property. To make it easier to get the data request ID after posting a data request, this PR also returns it in the execute message
PostDataRequest.Explanation of Changes
dr_idin response.data inpost_data_requestsI could not identify any other functions where return data is necessary.
Testing
n/a, tests still passing
Related PRs and Issues
Closes #51