Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create deploy all contracts workflow #75

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Conversation

jamesondh
Copy link
Contributor

Motivation

Reduce time to deploy all contracts.

Explanation of Changes

  • Created new workflow to deploy all contracts with one run, and to set the circular dependencies on the Proxy once the other contracts are deployed.
  • Echo contract name in deploy singular contract.
  • Remove deprecated deploy WASM storage contract workflow.

Testing

Tested on a fork.

Related PRs and Issues

Closes #74
Closes #72

@jamesondh jamesondh requested review from FranklinWaller and a team October 2, 2023 15:04
Copy link
Member

@Thomasvdam Thomasvdam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This simplifies things a lot. :) Maybe it's worth looking into making it a shell script in the repo so we can easily run it against a local chain. The pipeline can then just execute the shell script. We'll lose the steps as a progress indicator but I don't think that's too much of a problem.

Something else: in the future we might want to look at sharing code between pipeline templates. It's a bit of a hassle but in https://github.com/sedaprotocol/seda-explorer-fe/tree/main/.github I've managed to share some common code between pipelines. It's not the best, but beats having to remember to change 6 files when something changes in the build/deployment steps.

@gluax
Copy link
Collaborator

gluax commented Oct 6, 2023

@Thomasvdam if it helps I have this written up in a rust binary as well for the local chain. Would just need to change some stuff so it's not hard coded to the local chain. Also doesn't rely on docker to build the contracts! So it's a bit simpler.

@jamesondh jamesondh merged commit 483cbbf into main Oct 8, 2023
4 checks passed
@jamesondh jamesondh deleted the chore/deploy-all branch October 8, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants