Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new protobuf files and match latest version of chain #28

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

gluax
Copy link
Contributor

@gluax gluax commented Oct 24, 2024

Motivation

Adds the batching and private key modules.

Explanation of Changes

The two new modules are added. As well as the oracle program renames.

Testing

Works with the test suite :)

Related PRs and Issues

N/A

@gluax gluax self-assigned this Oct 24, 2024
@gluax gluax requested a review from FranklinWaller November 1, 2024 12:45
@Thomasvdam
Copy link
Member

Maybe good to use the proto files from the open PR on the chain side? Minor change to the pubkey module.

@gluax
Copy link
Contributor Author

gluax commented Nov 1, 2024

Maybe good to use the proto files from the open PR on the chain side? Minor change to the pubkey module.

Ah, I might wait on that, though, just because I don't know if it will get merged in and deployed by Monday, and I don't want to break Mario and Franklin's working with Planet.

Copy link
Member

@Thomasvdam Thomasvdam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't matter since those files are for modules we don't interact with, but by that same logic we can just merge this as is and wait for the next update that does actually change RPC calls we care about :D

@gluax gluax merged commit 1baab37 into main Nov 1, 2024
2 checks passed
@gluax gluax deleted the feat/protobuf-batching-pubkeys branch November 1, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants