Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check the individual commits and commit messages for what is wrong.
General Feedback
tra_demand
also emptytra_road_agri_ice_diesel_0
&tra_road_agri_ice_diesel_1
&tra_road_const_ice_diesel_1
&tra_road_mtruck_ice_frei_cng_0
&tra_road_mtruck_ice_frei_cng_1
and
and re-upload, as they're empty
Questions
tra_rail_train_pass_0
column:optional_limitations
: what is the informationunknown
good for?Generel impressions
You applied the majority of conventions already 😍
Please, check for consistency across all your tables additionally to my remarks.