Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review tra sector #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Review tra sector #4

wants to merge 1 commit into from

Conversation

chrwm
Copy link
Member

@chrwm chrwm commented Jun 5, 2024

Please check the individual commits and commit messages for what is wrong.

General Feedback

  1. Version should be srd_range_draft for all your tables. Needs to be changed for all tables
  2. Please, delete table tra_demand also empty
  3. Please, delete tables
    tra_road_agri_ice_diesel_0 &
    tra_road_agri_ice_diesel_1 &
    tra_road_const_ice_diesel_1 &
    tra_road_mtruck_ice_frei_cng_0 &
    tra_road_mtruck_ice_frei_cng_1
    and

grafik

and re-upload, as they're empty

  1. I analysed missing references to global tables:
table column reference_table missing_col_in_reference_table
0 tra_road_hcar_bev_pass_wallbox_flex_bi_g2v_0 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
1 tra_road_hcar_bev_pass_wallbox_flex_bi_g2v_1 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
2 tra_road_hcar_bev_pass_wallbox_flex_bi_v2g_0 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
3 tra_road_hcar_bev_pass_wallbox_flex_bi_v2g_1 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
4 tra_road_hcar_bev_pass_wallbox_flex_uni_g2v_0 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
5 tra_road_hcar_bev_pass_wallbox_flex_uni_g2v_1 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
6 tra_road_hcar_bev_pass_wallbox_inflex_uni_g2v_0 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
7 tra_road_hcar_bev_pass_wallbox_inflex_uni_g2v_1 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
8 tra_road_htruck_bev_frei_battery_flex_bi_0 sto_max_timeseries tra_timeseries sto_max_htruck
9 tra_road_htruck_bev_frei_battery_flex_bi_0 sto_min_timeseries tra_timeseries sto_min_htruck
10 tra_road_htruck_bev_frei_battery_flex_bi_1 sto_max_timeseries tra_timeseries sto_max_htruck
11 tra_road_htruck_bev_frei_battery_flex_bi_1 sto_min_timeseries tra_timeseries sto_min_htruck
12 tra_road_htruck_bev_frei_battery_flex_uni_0 sto_max_timeseries tra_timeseries sto_max_htruck
13 tra_road_htruck_bev_frei_battery_flex_uni_0 sto_min_timeseries tra_timeseries sto_min_htruck
14 tra_road_htruck_bev_frei_battery_flex_uni_1 sto_max_timeseries tra_timeseries sto_max_htruck
15 tra_road_htruck_bev_frei_battery_flex_uni_1 sto_min_timeseries tra_timeseries sto_min_htruck
16 tra_road_htruck_bev_frei_wallbox_flex_bi_g2v_0 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
17 tra_road_htruck_bev_frei_wallbox_flex_bi_g2v_1 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
18 tra_road_htruck_bev_frei_wallbox_flex_bi_v2g_0 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
19 tra_road_htruck_bev_frei_wallbox_flex_bi_v2g_1 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
20 tra_road_htruck_bev_frei_wallbox_flex_uni_g2v_0 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
21 tra_road_htruck_bev_frei_wallbox_flex_uni_g2v_1 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
22 tra_road_htruck_bev_frei_wallbox_inflex_uni_g2v_0 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
23 tra_road_htruck_bev_frei_wallbox_inflex_uni_g2v_1 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
24 tra_road_htruck_ice_frei_lng_0 ef_sec_lng_emi_co2_f_tra global_emission_factors sec_lng
25 tra_road_htruck_ice_frei_lng_1 ef_sec_lng_emi_co2_f_tra global_emission_factors sec_lng
26 tra_road_lcar_bev_pass_wallbox_flex_bi_g2v_0 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
27 tra_road_lcar_bev_pass_wallbox_flex_bi_g2v_1 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
28 tra_road_lcar_bev_pass_wallbox_flex_bi_v2g_0 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
29 tra_road_lcar_bev_pass_wallbox_flex_bi_v2g_1 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
30 tra_road_lcar_bev_pass_wallbox_flex_uni_g2v_0 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
31 tra_road_lcar_bev_pass_wallbox_flex_uni_g2v_1 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
32 tra_road_lcar_bev_pass_wallbox_inflex_uni_g2v_0 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
33 tra_road_lcar_bev_pass_wallbox_inflex_uni_g2v_1 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
34 tra_road_ltruck_bev_frei_battery_flex_bi_0 sto_max_timeseries tra_timeseries sto_max_ltruck
35 tra_road_ltruck_bev_frei_battery_flex_bi_0 sto_min_timeseries tra_timeseries sto_min_ltruck
36 tra_road_ltruck_bev_frei_battery_flex_bi_1 sto_max_timeseries tra_timeseries sto_max_ltruck
37 tra_road_ltruck_bev_frei_battery_flex_bi_1 sto_min_timeseries tra_timeseries sto_min_ltruck
38 tra_road_ltruck_bev_frei_battery_flex_uni_0 sto_max_timeseries tra_timeseries sto_max_ltruck
39 tra_road_ltruck_bev_frei_battery_flex_uni_0 sto_min_timeseries tra_timeseries sto_min_ltruck
40 tra_road_ltruck_bev_frei_battery_flex_uni_1 sto_max_timeseries tra_timeseries sto_max_ltruck
41 tra_road_ltruck_bev_frei_battery_flex_uni_1 sto_min_timeseries tra_timeseries sto_min_ltruck
42 tra_road_ltruck_bev_frei_wallbox_flex_bi_g2v_0 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
43 tra_road_ltruck_bev_frei_wallbox_flex_bi_g2v_1 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
44 tra_road_ltruck_bev_frei_wallbox_flex_bi_v2g_0 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
45 tra_road_ltruck_bev_frei_wallbox_flex_bi_v2g_1 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
46 tra_road_ltruck_bev_frei_wallbox_flex_uni_g2v_0 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
47 tra_road_ltruck_bev_frei_wallbox_flex_uni_g2v_1 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
48 tra_road_ltruck_bev_frei_wallbox_inflex_uni_g2v_0 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
49 tra_road_ltruck_bev_frei_wallbox_inflex_uni_g2v_1 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
50 tra_road_ltruck_ice_frei_lng_0 ef_sec_lng_emi_co2_f_tra global_emission_factors sec_lng
51 tra_road_ltruck_ice_frei_lng_1 ef_sec_lng_emi_co2_f_tra global_emission_factors sec_lng
52 tra_road_mcar_bev_pass_wallbox_flex_bi_g2v_0 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
53 tra_road_mcar_bev_pass_wallbox_flex_bi_g2v_1 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
54 tra_road_mcar_bev_pass_wallbox_flex_bi_v2g_0 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
55 tra_road_mcar_bev_pass_wallbox_flex_bi_v2g_1 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
56 tra_road_mcar_bev_pass_wallbox_flex_uni_g2v_0 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
57 tra_road_mcar_bev_pass_wallbox_flex_uni_g2v_1 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
58 tra_road_mcar_bev_pass_wallbox_inflex_uni_g2v_0 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
59 tra_road_mcar_bev_pass_wallbox_inflex_uni_g2v_1 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
60 tra_road_mcar_ice_pass_lpg_0 ef_sec_lpg_emi_co2_f_tra global_emission_factors sec_lng
61 tra_road_mcar_ice_pass_lpg_1 ef_sec_lpg_emi_co2_f_tra global_emission_factors sec_lng
62 tra_road_mtruck_bev_frei_battery_flex_bi_0 sto_max_timeseries tra_timeseries sto_max_mtruck
63 tra_road_mtruck_bev_frei_battery_flex_bi_0 sto_min_timeseries tra_timeseries sto_min_mtruck
64 tra_road_mtruck_bev_frei_battery_flex_bi_1 sto_max_timeseries tra_timeseries sto_max_mtruck
65 tra_road_mtruck_bev_frei_battery_flex_bi_1 sto_min_timeseries tra_timeseries sto_min_mtruck
66 tra_road_mtruck_bev_frei_battery_flex_uni_0 sto_max_timeseries tra_timeseries sto_max_mtruck
67 tra_road_mtruck_bev_frei_battery_flex_uni_0 sto_min_timeseries tra_timeseries sto_min_mtruck
68 tra_road_mtruck_bev_frei_battery_flex_uni_1 sto_max_timeseries tra_timeseries sto_max_mtruck
69 tra_road_mtruck_bev_frei_battery_flex_uni_1 sto_min_timeseries tra_timeseries sto_min_mtruck
70 tra_road_mtruck_bev_frei_wallbox_flex_bi_g2v_0 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
71 tra_road_mtruck_bev_frei_wallbox_flex_bi_g2v_1 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
72 tra_road_mtruck_bev_frei_wallbox_flex_bi_v2g_0 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
73 tra_road_mtruck_bev_frei_wallbox_flex_bi_v2g_1 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
74 tra_road_mtruck_bev_frei_wallbox_flex_uni_g2v_0 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
75 tra_road_mtruck_bev_frei_wallbox_flex_uni_g2v_1 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
76 tra_road_mtruck_bev_frei_wallbox_inflex_uni_g2v_0 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries
77 tra_road_mtruck_bev_frei_wallbox_inflex_uni_g2v_1 capacity_tra_connection_timeseries tra_timeseries capacity_tra_connection_timeseries

Questions

  1. in tra_rail_train_pass_0 column: optional_limitations: what is the information unknown good for?

Generel impressions

You applied the majority of conventions already 😍
Please, check for consistency across all your tables additionally to my remarks.

The correct version in this state should be: srd_range_draft
@chrwm chrwm added the review Formal review of data tables label Jun 5, 2024
@HeddaElisabethGardian
Copy link

Kerstin gave me the following answer concerning the optional_limitations question: "wir hatten die Spalte gemacht für mögliche Constraints (also Beschränkungen). Gerade steht aber unknown drinnen, da wir es einfach leer lassen wollten."

Base automatically changed from review-srd-2024-06-04 to main July 22, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Formal review of data tables
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants