Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mentor country details #171

Merged

Conversation

Disura-Randunu
Copy link
Contributor

Purpose

The purpose of this PR is to fix #155

Goals

To save Country details on Mentor

Approach

Added relations and modified controllers & services to create & update mentors.
Also updated how category was handled in Update mentor route for admins as there were unnecassary type checks

Screenshots

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

#169
#170

Test environment

Learning

@Disura-Randunu
Copy link
Contributor Author

@anjula-sack Made the PR for #155
Also updated categoryId handling on previously made admin api to update mentor as there were unnecessary type checks

@Disura-Randunu
Copy link
Contributor Author

@anjula-sack We may have to make the DB modifications first. otherwise it'll give an error when fetching the mentor details

@anjula-sack anjula-sack changed the base branch from main to development October 2, 2024 07:09
Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @Disura-Randunu

@anjula-sack anjula-sack merged commit 91b32c5 into sef-global:development Oct 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement standardized country flag data for mentor profiles
2 participants