[Feature/board] member 권한 검사 기능 추가 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Repactoring/member] 인증 정보 없을경우 에러 처리 및 Converter 를 통한 암호화
Feature/board
HwangHarim
changed the title
InJun2
reviewed
Aug 24, 2023
Comment on lines
46
to
57
| public void update(Long boardId, UpdateBoardRequest request, UserDetail userInfo) { | ||
| if (boardRepository.existsByIdAndMemberId( | ||
| boardId, userInfo.getId()) && | ||
| (userInfo.getRoleType() | ||
| .equals(RoleType.LAB_LEADER) || | ||
| userInfo.getRoleType() | ||
| .equals(RoleType.LAB_USER))) { | ||
| throw new UnauthorizedAccessException( | ||
| UNAUTHORIZED_ACCESS_EXCEPTION, | ||
| "권한이 없는 접근입니다." | ||
| ); | ||
| } |
There was a problem hiding this comment.
Board에 boardId와 memberId가 일치하고 랩장이나 유저가 맞는데 에러처리를 발생하고 있는건가요?
There was a problem hiding this comment.
오류가 있었네요 수정해서 올리겠습니다. 감사합니다.
Comment on lines
70
to
78
| if (userInfo.getRoleType() | ||
| .equals(RoleType.LAB_LEADER) || | ||
| userInfo.getRoleType() | ||
| .equals(RoleType.LAB_USER)) { | ||
| throw new UnauthorizedAccessException( | ||
| UNAUTHORIZED_ACCESS_EXCEPTION, | ||
| "권한이 없는 접근입니다." | ||
| ); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 개요
📑 작업 사항
Repository
Service
Controller
converter
error
✒️ 코드 리뷰 요청 사항
✔️ 코드 리뷰 반영 사항