Use branch when checking for new commits #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Check v:vim_did_enter and call for debugging convenience
There was a lot of strange behavior in vimscript version of this plugin. The on_stdout callback appeared to be called a variable number of times before the on_exit callback, most likely indicating a race. I tried refactoring to call the rev-list command sequentially for each plugin in an async cascade, but for unknown reasons, stdout was blank for about half of the calls in my setup. In python, we can use a comparatively simple synchronous function wrapped in vim.async_call, so that's what I've done. The plugin now appears to finally work consistently and as expected. Since async/job.vim is no longer needed, I've removed that as well.
vim.eval returns a string, whereas we need an int for boolean testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes /issues/14 for me (I have coc.nvim checked out from the release branch). Thanks for the very useful plugin.