-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: releaseNameTemplate
and releaseBodyTemplate
options
#704
feat: releaseNameTemplate
and releaseBodyTemplate
options
#704
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great pull request, thank you! I'm okay to merge as is but have a suggestion
README.md
Outdated
| `releaseName` | A [Lodash template](https://lodash.com/docs#template) to customize the github release's name | `<%= nextverison.name %>` | | ||
| `releaseBody` | A [Lodash template](https://lodash.com/docs#template) to customize the github release's body | `<%= nextverison.notes %>` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we rename the arguments to releaseNameTemplate
/releaseBodyTemplate
for clarity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, updated
50bf672
to
e913ee5
Compare
releaseNameTemplate
and releaseBodyTemplate
options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
e913ee5
to
ea9d8e6
Compare
I stupidly clicked the rebase with master, so CI will need to be re-approved sorry |
🎉 This PR is included in version 9.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I want to be able to be able to add some installation instructions and other preambles to each release. This seemed like the simplest way to do that, as well as handle #498