Feat/v4 contracts #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR implements extension contracts using version 4 re semaphore-protocol/semaphore#353
… and README Removed the need of merkletreesize whcih came with v3
switch @semaphore-protocol/contracts from a dev dependecy to a dependency
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cedoor
requested changes
Jul 17, 2024
There was a problem hiding this comment.
Hey @Dozie2001, thanks for this PR!
First round of review. I haven't seen the code yet but let's start with this config stuff and documentation.
A sym link of contracts/contracts/README.md to contracts/README.md
cedoor
requested changes
Jul 23, 2024
… am using the interface re n
cedoor
requested changes
Jul 29, 2024
cedoor
requested changes
Aug 1, 2024
cedoor
requested changes
Aug 5, 2024
cedoor
requested changes
Aug 7, 2024
cedoor
requested changes
Aug 7, 2024
cedoor
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
There are still some issues with config files but we'll fix them after merging. I think the PR is ready.
Thanks a lot @Dozie2001 🙏🏽
cedoor
merged commit fa9a0da
into
semaphore-protocol:chore/contract-extensions
1 of 4 checks passed
cedoor
added a commit
that referenced
this pull request
Aug 29, 2024
* Feat/v4 contracts (#14) * feat(contracts)!: introduces Semaphore extension contracts with v4 This PR implements extension contracts using version 4 re semaphore-protocol/semaphore#353 * refactor(contracts): fixing the voters contracts * docs(contracts): updated instructions on setting up contracts * ci(contracts): scripts that deploy contracts and gets addresses * test(contracts): added test for both whistleblowing and voting * refactor(contracts): refactored contracts to use v4 and added license and README Removed the need of merkletreesize whcih came with v3 * build(contracts): added dependencies and deploye contracts N * chore(contracts): corrected dependency switch @semaphore-protocol/contracts from a dev dependecy to a dependency * docs(contracts): refactored the docs * chore(contracts): fixed documentation and configuration files * docs(contracts): created a sym link to README A sym link of contracts/contracts/README.md to contracts/README.md * ci(contracts): added scripts to test and compile * ci(contracts): fixed config files and solhint script * docs(contracts): made README docs more general * fix(contracts): fixed event errors * refactor(contracts): changed the groups variable to semaphore since I am using the interface re n * refactor(contracts): removed unsused argument * fix(contracts): refactored the contracts and removed unuses parameters * docs(contracts): updated Documentation by removing groupId re N * refactor(contracts): removed inheritance from SemaphoreGroups * refactor(contracts): removed SemaphoreGroups import * fix(contracts): added proof Validation and fixed contracts deploy * refactor(contracts): refactored code and removed bool value in saved nullifier * refactor(contracts): removed nullifiers redudant mapping * chore: include contracts in scripts * fix(contracts): fix contract extensions (#16) * chore: update dependencies * docs: add contracts package to readme * refactor(contracts): update visibility of some functions (#17) --------- Co-authored-by: Chidozie DAVID <[email protected]> Co-authored-by: Vivian Plasencia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the semaphore extension contracts to use the v4
@semaphore-protocol/contractsand moves them to the extensions repoIt removes the need for tree depth in Groups
Related Issue(s)
Closes #353
Other information
Checklist
yarn stylewithout getting any errors