Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new semaphore explorer to apps #19

Merged
merged 5 commits into from
Nov 28, 2024
Merged

feat: add new semaphore explorer to apps #19

merged 5 commits into from
Nov 28, 2024

Conversation

vplasencia
Copy link
Member

@vplasencia vplasencia commented Nov 27, 2024 •
edited
Loading

Description

This PR:

  • Adds the new Semaphore explorer.
  • Fixes some lint issues in the explorer.
  • Fixes the private property in the contracts package.json file. From "true" -> true.

Related Issue(s)

Re #1

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn style without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vplasencia vplasencia requested a review from a team as a code owner November 27, 2024 17:33
@vercel Vercel
Copy link

vercel bot commented Nov 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
semaphore-benchmarks ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 8:57am

cedoor
cedoor requested changes Nov 28, 2024
View reviewed changes
apps/explorer/LICENSE Outdated Show resolved Hide resolved
apps/explorer/README.md Outdated Show resolved Hide resolved
vplasencia and others added 3 commits November 28, 2024 09:54
@vplasencia @cedoor
Update apps/explorer/LICENSE
b3b77a6 
Co-authored-by: Cedoor <[email protected]>
@vplasencia @cedoor
Update apps/explorer/README.md
e4f6d4b 
Co-authored-by: Cedoor <[email protected]>
@vplasencia
feat: improve explorer ux (#20)
a0dcf4d 
* fix(explorer): fix filtered groups search

* feat(explorer): add loader to pages

* chore(explorer): add website metadata
@vplasencia vplasencia requested a review from cedoor November 28, 2024 08:57
@vplasencia vplasencia merged commit 317f6fe into main Nov 28, 2024
4 checks passed
@vplasencia vplasencia deleted the feat/add-explorer branch November 28, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedoor cedoor Awaiting requested review from cedoor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vplasencia @cedoor