fix(explorer): sort group response by id in ascending order #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously displayed group response objects inconsistently, change offers better readability to users
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cedoor
approved these changes
Dec 10, 2024
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 Semaphore Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously displayed group response objects inconsistently, change offers better readability to users
Description
Group response objects weren't sorted prior, as a result, the ordering of the items were inconsistent.
Fix (readability)
Items now displayed in ascending order by ID on the homepage
The parseInt function takes a radix as an optional second param, I've used 10 so as to satisfy the linter. Considered using - Number(a.id) - Number(b.id) - instead to convert the string to int but for the possibility of it returning NaN. ParseInt will always return a number and therefore minimise further issues arising.
Before
After