added postgres and ldap support to compose #948 #954
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tiny6996 Did you test this changes? |
|
Yes I have tested this change with podmanc-compose and docker compose |
fiftin
force-pushed
the
develop
branch
2 times, most recently
from
0c60a1b
to
d3dfbf0
Compare
readded version number
fixed proper spacing
|
This docker-compose file used only for integration tests. We don't test LDAP. I will add integration tests for all databases soon and we will have 3 docker compose files. |
|
I closing this PR, but I sure these changes should be reflected in the documentation. Related to semaphoreui/semaphore-docs#3. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes the postgres and ldap options in the dev config. I didn't add postgres to prod config since I have having issues with that setup in testing.